Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: Update information regarding Google Play in README #4015

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

fornwall
Copy link
Member

The current information is generating a lot of confusion, hopefully this updated one feels ok?

@finagolfin
Copy link
Member

Thanks, @agnostic-apollo is busy, so @Grimler91 asked me to take a look at this. I will read through it and get back to you tomorrow.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fornwall fornwall force-pushed the readme-google-play branch from d014661 to 3abed51 Compare June 14, 2024 13:57
README.md Outdated Show resolved Hide resolved
@fornwall fornwall force-pushed the readme-google-play branch from 3abed51 to 0dd3e5a Compare June 14, 2024 14:04
Copy link
Member

@Grimler91 Grimler91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks, see additional comments and suggestions below

README.md Outdated
</details>

##
Currently, Google Play will try to update installations away from F-Droid ones. Updating will still fail as [sharedUserId](https://developer.android.com/guide/topics/manifest/manifest-element#uid) has been removed. This will be fixed in a `0.118.1` version update on F-Droid shortly, which will update the version code so that Google Play does not considers its version of the app newer. Meanwhile, to prevent PlayStore from attempting to download and then fail to install the Google Play releases over existing installations, you can open the Termux apps pages on Google Play and then click on the 3 dots options button in the top right and then disable the Enable auto update toggle. However, the Termux apps updates will still show in the PlayStore app updates list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed in a 0.118.1 version update on F-Droid shortly, which will update the version code so that Google Play does not considers its version of the app newer
->
A planned 0.118.1 F-Droid release will fix this by setting a higher version code than used for the PlayStore app

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph will be helpful to users that see the update in PlayStore and are confused, thanks

README.md Outdated

If you want to help out with testing the Google Play build (or cannot install Termux from other sources), be aware that it's built from a separate repository (https://github.com/termux-play-store/) - be sure to report issues [there](https://github.com/termux-play-store/termux-issues/issues/new/choose), as any issues might very well be specific to that repository and not relevant for the main Termux ones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two last paragraphs can be shortened, playstore specific info should go in the playstore repo. The play-store app repo is built from a quite different code base, and is for most purposes a fork of github.com/termux/termux-app at this point. As an alternative I propose:

A Termux app built from different sources is available from Google Play for Android 11+ devices. It is under development and has missing functionality and bugs compared to F-Droid and GitHub releases (see #4000). Issues with PlayStore app are off-topic here and should be reported in a separate organisation.

README.md Outdated

**Termux and its plugins are no longer updated on [Google Play Store](https://play.google.com/store/apps/details?id=com.termux) due to [android 10 issues](https://github.com/termux/termux-packages/wiki/Termux-and-Android-10) and have been deprecated.** The last version released for Android `>= 7` was `v0.101`. **It is highly recommended to not install Termux apps from Play Store any more.**
Most users should use the F-Droid or GitHub installation source as described above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I shortened info below I suggest here instead:

Most users should use the F-Droid or GitHub installation source as described above, to get a stable experience and access to all packages.

@@ -114,45 +114,15 @@ Version: 3

</details>

### Google Play Store **(Deprecated)**
### Google Play Store **(Experimental branch)**
Copy link
Member

@Grimler91 Grimler91 Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a branch in this repo, as an alternative I propose External fork by @fornwall

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that's mainly not to clutter this repo's issues with the PS-specific questions, I'd imagine. The app is just a branch off our older app code that @fornwall plans to integrate back eventually.

I'll let you two hash out this title.

@fornwall fornwall force-pushed the readme-google-play branch from 989f675 to d56f0ae Compare June 15, 2024 23:08
@fornwall
Copy link
Member Author

I went ahead and merged this as it's causing so much confusion & frustration - let me know about any follow up and I'll look into it!

I did not include a link to #4000 as that's not really helping things - it's outdated regarding what's included (e.g. storage permissions) and is incorrectly stating things about starting from an old version. Unless that's fixed and continuously updated it's not a good source to refer to.

Regarding branding attempts trying to paint Termux on Google Play as a fork/unofficial build of Termux: That's not going to work and is not helpful. Termux on Google Play was the original source of Termux, has millions of active installs and is useful to a huge amount of people around the world who can't install from non-Google Play sources.

While I'll certainly agree that it's painful with the divergence between the Google Play build and this repository, we need to learn to make the best out of it, work together and behave well towards each other while things are being sorted out (and try to finally get out of the situation where this repository has been blocked from contributions for soon two years, due to the huge amount of local changes that hasn't been pushed).

@fornwall fornwall merged commit d90be9c into master Jun 15, 2024
4 checks passed
@fornwall fornwall deleted the readme-google-play branch June 15, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants